all lights work but car wont start. thought it was the starter but wasnt any ideas?

Throwing parts at a problem gets expensive, especially in vehicles with computer controlled engines. I suggest you do checking first before spending money. Get a repair manual for your vehicle, and a decent ohm meter. First, check and make sure spark is getting to the plugs, then check fuel pressure, then make sure there is no restriction in the air filter leading to the intake. The NET is a good place to browse for your particular make and model